Trying to improve x49gp
|
12-02-2021, 02:39 PM
Post: #89
|
|||
|
|||
RE: Trying to improve x49gp
I noticed Eric uploaded the bootloaders, so I tested the script and worked flawlessly.
Now as far as the Makefile, the pull request I received tries to fix the folders, but we really need to remove all references to the firmware from the Makefile. The Makefile should NEVER pull binaries, that needs to be left for the post-installation script of the package. If the user is building directly from sources, then the user needs to manually run pull-roms.sh afterwards. If installing via apt/yum, etc. then the package should automatically run the script after installing x49gp. It's important for 2 things: * Building x49gp should not depend on whether those binaries are available or not. * Binaries need to be pulled by the final user, not the person building the package. |
|||
« Next Oldest | Next Newest »
|
User(s) browsing this thread: 2 Guest(s)