Trying to improve x49gp

[3298]

So you are this datajerk? I guess I didn't read the readme thoroughly enough.

The Makefie fix for Ubuntu present in that Git repo does its job, but on my system I'm running into another error which is shown as this:

Code:

/usr/bin/ld: ui.o: undefined reference to symbol 'floor@@GLIBC_2.0'
/usr/lib/libm.so.6: error adding symbols: DSO missing from command line

The fix was to link against libm, which led to a similar error about a function from libz. These are why I added -lm -lz to the LDFLAGS. For reference, the system is Manjaro (an Arch-based distro, rolling release, hence no version number other than "current"). I don't have a Mac to try the OSX compilation on, so there's little I can do about that.
Does the addition of -lm -lz break compilation on some system?

Also, I should mention that my tests with the grayscale patch were just "look whether it works at all". The stack showed up properly, meaning the monochrome mode works, and I opened a 4-bit grayscale GROB with OpenFire's viewer, which also looked like I expected. The palette register for 2-bit grayscale wasn't tested, but HPGCC3's grayscale mode switch routine refers to the word at an offset of 10 32-bit words as the palette register, which is the one called bluelut in x49gp's data structure. So in theory it should work once a silly mistake on my side is fixed: in s3c2410_lcd.c:117 I wrote

Code:

return 15 & (lcd->bluelut >> (2 * data));

which was supposed to shift the appropiate part of the palette register to the LSB end (data contains the 2-bit color). The 2 * data should be 4 * data because the colors in the palette register are 4 bits wide, of course.
Could someone confirm that grayscale works on other systems as well? I'm kinda new to X server graphics, so I could have done something non-portable. One of my attempts involved calling the wrong GDK function in the places where the foreground color is set, which made the virtual screen turn black.
The color selection is a bit lacking, too. I took the screen color of the calc pictures (171, 210, 180 in RGB) and scaled each component by the desired grayscale value.