The Museum of HP Calculators

HP Forum Archive 20

[ Return to Index | Top of Index ]

WP 34s: UP and Down key in program mode
Message #1 Posted by Miguel Toro on 2 Nov 2011, 10:21 a.m.

Hi,

Using version 2.2 rev. 1782, I see that in program mode, when I keep the up key pressed, the calculator does a fast up-scroll through the steps of a program, but if do the same with the Down key, I just get a NULL and nothing else happens, so think is a little inconsistent. Is that the intended behaviour?

Thanks,

Miguel

      
Re: WP 34s: UP and Down key in program mode
Message #2 Posted by Dominic Richens on 2 Nov 2011, 12:29 p.m.,
in response to message #1 by Miguel Toro

the keys.c code to handle SST versus BST is different:

		case STATE_SST:
			xeq_sst_bst(0);
			OpCode = c;
			OpCodeDisplayPending = 0;
			break;
		case STATE_BST:
			xeq_sst_bst(-1);
			break;

stepping works properly if those OpCode* lines are removed, or at least if OpCode is set to 0 on STATE_SST - not sure why those lines are there, though.

Edited: 2 Nov 2011, 12:29 p.m.

            
Re: WP 34s: UP and Down key in program mode
Message #3 Posted by Marcus von Cube, Germany on 2 Nov 2011, 4:12 p.m.,
in response to message #2 by Dominic Richens

I changed this because I think it's a good idea to be able to NULL a command that is selected via SST. You see the command before it is executed and holding the key longer cancels it. This is, of course, incompatible with the autorepeat feature. The latter is therefore disabled for SST.

EDIT: In program mode, autorepeat should work. I've to check this.

Edited: 2 Nov 2011, 4:16 p.m.

                  
Re: WP 34s: UP and Down key in program mode
Message #4 Posted by Walter B on 2 Nov 2011, 4:35 p.m.,
in response to message #3 by Marcus von Cube, Germany

Please look here.

      
Re: WP 34s: UP and Down key in program mode
Message #5 Posted by Walter B on 2 Nov 2011, 4:06 p.m.,
in response to message #1 by Miguel Toro

Both directions should work symmetrically. What you observed is *not* the intended behaviour.

            
Re: WP 34s: UP and Down key in program mode
Message #6 Posted by Marcus von Cube, Germany on 2 Nov 2011, 4:41 p.m.,
in response to message #5 by Walter B

Yes, but only in program mode. I found the error. It's not in the keyboard handler but in xeq_bst_sst(). It will be fixed in an upcoming release.

In run mode, SST and BST are not symmetrical by design: A SST executes the instruction while BST only displays it. So autorepeat is fine for BST but for SST, NULLing makes more sense.

Edit: Fixed and committed but the present release is unstable so please be patient!

Edited: 2 Nov 2011, 4:58 p.m.

                  
Re: WP 34s: UP and Down key in program mode
Message #7 Posted by Cristian Arezzini on 3 Nov 2011, 12:41 a.m.,
in response to message #6 by Marcus von Cube, Germany

I used to be able to reflash the calc without losing data - a "Backup to flash" would leave me with a calc displaying "Restored" after flash. Now it's very common that after flashing I get "Erased" and I have to transfer my programs again. Should I stop updating for a while until things "settle down" a little?

Cristian

                        
Re: WP 34s: UP and Down key in program mode
Message #8 Posted by Walter B on 3 Nov 2011, 3:18 a.m.,
in response to message #7 by Cristian Arezzini

v2.3 is pretty much a playground (or construction site) for new stuff to come with v3.0. Thus we closed v2.2.

                              
Re: WP 34s: UP and Down key in program mode
Message #9 Posted by Jeff O. on 3 Nov 2011, 8:47 a.m.,
in response to message #8 by Walter B

Which revision number is the final 2.2? Is it considered stable?

                                    
Re: WP 34s: UP and Down key in program mode
Message #10 Posted by Marcus von Cube, Germany on 3 Nov 2011, 9:05 a.m.,
in response to message #9 by Jeff O.

I've put up a V2.2 earlier as a release package. This should work even with some minor problems left.

                                    
Re: WP 34s: UP and Down key in program mode
Message #11 Posted by fhub on 3 Nov 2011, 9:58 a.m.,
in response to message #9 by Jeff O.

Quote:
Which revision number is the final 2.2? Is it considered stable?
I have SVN1797 as lastest (stable) 2.2 version.
After that Marcus introduced these new feature like LOCL, adresses with ".nnn" etc...

Franz

                                          
Re: WP 34s: UP and Down key in program mode
Message #12 Posted by Jeff O. on 3 Nov 2011, 12:31 p.m.,
in response to message #11 by fhub

Thanks.
The version in the release package is "only" 1790. I'd hate to miss out on any improvements.

For what it is worth, through trial and error I determined that rev. 1805 is the last one identified as 2.2, with rev. 1806 and later being 2.3.

                                                
Re: WP 34s: UP and Down key in program mode
Message #13 Posted by fhub on 3 Nov 2011, 12:43 p.m.,
in response to message #12 by Jeff O.

Quote:
For what it is worth, through trial and error I determined that rev. 1805 is the last one identified as 2.2, with rev. 1806 and later being 2.3.
Yes, but a few versions after 1797 (where some new features were implemented) didn't work correctly here - I couldn't even load flash files compiled with the assembler. So I don't think it's a good idea to use these SVNs.
                                                
Re: WP 34s: UP and Down key in program mode
Message #14 Posted by Marcus von Cube, Germany on 3 Nov 2011, 2:34 p.m.,
in response to message #12 by Jeff O.

1805 isn't very stable. Stick to an older release!

The current build is starting to get stable with all the new bells and whistles but with a slightly modified layout. The medium emulator skin is adapted (select option 4).

[ Return to Index | Top of Index ]

Go back to the main exhibit hall