Trying to improve x49gp

[3298]

(10-10-2018 02:25 PM)Claudio L. Wrote:  Done, patches 34,35 and 36, as well as removal of that old file are committed to the repo.

Thanks! That was quick. Looks like our faithful customer brickviking is already happy.

(10-10-2018 02:25 PM)Claudio L. Wrote:  I also made a couple of changes to complement your own about the deleted labels that shouldn't have been deleted:
* I changed the word "MAIN" on P with "MENU", I think it's clearer.
* Added PREV.M, DEL, ABS, ARG, PRG, NUM.SLV, TIME, CONVERT, BASE, LIB, CMPLX, ARITH and ENTRY missing labels, as those keys are implemented.
* I also added CUT, COPY and PASTE, as well as BEG, END, and UPDIR to the cursors. Doesn't look too great but they are all important shortcuts to remember.

So go ahead, pull and rebuild.

See, that's the benefit of having the main newRPL developer in the loop - x49gp gets more up-to-date keyboard labels than newRPL's own simulator! (Just teasing you ... but the simulator should probably get those labels too, eventually. A cropped x49gp screenshot would do in a pinch.)

The cursor key labels do indeed look a bit weird due to their collision with the edges of the inset area between the cursor keys, but maybe we could move the texts around. Especially the texts above the left and right keys get uncomfortably close to the up key. They could be shoved away by adding spaces (kind of hacky, but it works) at the right end of the left key's text and at the left end of the right key's text, and perhaps a letter could be dropped... BEG and END are already as short as they can be without making them too hard to understand, COPY could maybe lose the O (pretty much everybody understands CPY), but PASTE ? Would PSTE be understandable enough? I'm not sure.
I tried changing the texts to

Code:

"BEG CPY   "

(3 spaces at the end) and

Code:

"      END PASTE"

(6 spaces at the start), and I think it looked better already. It would be even better if they could also go up a few pixels because the labels look like they are touching their keys (just one or two pixels, otherwise "UPDIR" collides with F5), but that would need a special case in the drawing code (we could check for key->shape==UI_SHAPE_BUTTON_ROUND). I haven't done that yet; I'm sure it would be simple though. By the way, the main and letter labels didn't need to be changed from NULL to "", that was only necessary for the on-key labels, not the adjacent ones. There are other places where you switched from NULL to "": on Alpha, 2, 7, and 9 the letter and the leftshift labels are affected, on 1 just the letter label. For the letter labels this doesn't do anything, for the leftshift labels this causes the rightshift label to be right-aligned above the key. That of course isn't tragic either, but combined with the single-shift-label keys that came from my patch (which get centered due to the use of NULL; currently ASIN, ACOS, ATAN, CLEAR (see below), OFF, ->NUM) this creates a slight visual inconsistency.
DEL is on the list of the labels you said were added back, but I can't find it ...? I'm assuming it should be in its old position as left-shift label of backspace, but that is still NULL.
And finally, what about the CANCEL label below ON? Should that be restored as well, or does interrupting a program work different enough on newRPL that it's better to leave it out? (You can probably tell I never got around to testing newRPL myself.)