WP 34S and 31S bugs and fixes
|
11-26-2014, 10:07 PM
(This post was last modified: 11-26-2014 10:10 PM by pascal_meheut.)
Post: #18
|
|||
|
|||
RE: WP 34S and 31S bugs and fixes
(11-26-2014 07:56 PM)Bit Wrote: The mentioned two names are clear but what about the adapter function? It's in C++ code but declared extern "C" and on top of that its name refers to a C variable in camelcase (following the convention already used for some similar variables in C code). Would you like to call it increment_on_key_ticks_adapter or something else? As it is a C function, I would named it using the _ convention, so increment_on_key_ticks_adapter indeed. In the same file, you have is_key_pressed_adapter or get_region_path_adapter for instance. (11-26-2014 10:01 PM)Paul Dale Wrote: I suspect I'm the most guilty for inconsistently naming things through the code base I did not notice and found the project to be well-written and the code easy to understand when I started working on it. I've seen much worse. |
|||
« Next Oldest | Next Newest »
|
User(s) browsing this thread: 2 Guest(s)