WP 34S and 31S bugs and fixes

[Bit]

(11-26-2014 07:32 PM)pascal_meheut Wrote:  The convention I used is to follow the same for C code: _ to separate the words, lowercase.
For C++ methods, I used a common convention in object-oriented code: no _, first character in lower case, each word starting with an uppercase character.
Because increment_OnKeyTicks is a C++ method of QtKeyboard, it should be incrementOnKeyTicks (and update_OnKeyTicks should be updateOnKeyTicks).

I know I'm a bit anal about it but it helps code reading.

Consistency is naming is very useful, no need to apologize.

The mentioned two names are clear but what about the adapter function? It's in C++ code but declared extern "C" and on top of that its name refers to a C variable in camelcase (following the convention already used for some similar variables in C code). Would you like to call it increment_on_key_ticks_adapter or something else?