The Museum of HP Calculators

HP Forum Archive 20

[ Return to Index | Top of Index ]

34S - Problem With CLx
Message #1 Posted by Jake Schwartz on 16 July 2011, 1:50 p.m.

Hi,

While debugging a program on the 34S side-by-side with a 15C, I noticed that in the 34S, currently CLx leaves stack lift enabled, which is not the way HP calcs work. In the HP machines, the purpose of disabling stack lift with CLx was so if an erroneous number was entered, CLx would allow entering a replacement value without affecting the stack. For consistency, they kept this behavior the same while running in a program as well.

Hopefully, it makes sense to change this so it works in the 34S like all other RPN machines.

Thanks, Jake

      
Re: 34S - Problem With CLx
Message #2 Posted by gene wright on 16 July 2011, 2:02 p.m.,
in response to message #1 by Jake Schwartz

Agreed.

5 ENTER 6 CLX 8 + should return 13, not 8 as it does now.

Good catch, Jake!

            
Re: 34S - Problem With CLx
Message #3 Posted by Marcus von Cube, Germany on 16 July 2011, 4:56 p.m.,
in response to message #2 by gene wright

I think this can be done. Thanks for testing.

      
Re: 34S - Problem With CLx
Message #4 Posted by Paul Dale on 16 July 2011, 9:08 p.m.,
in response to message #1 by Jake Schwartz

Definitely a bug, I've got two fixes. One is much cleaner, a tiny bit larger and changers many opcodes. The other is ugly.

- Pauli

            
Re: 34S - Problem With CLx
Message #5 Posted by Paul Dale on 16 July 2011, 9:15 p.m.,
in response to message #4 by Paul Dale

And the ugly but smaller fix is applied.

- Pauli

                  
Re: 34S - Problem With CLx
Message #6 Posted by gene wright on 16 July 2011, 9:57 p.m.,
in response to message #5 by Paul Dale

Wow. That was fast. So the CLX + bug is fixed as well as the stack lift issue with PI or a constant?

Very nice!

                        
Re: 34S - Problem With CLx
Message #7 Posted by Paul Dale on 17 July 2011, 2:45 a.m.,
in response to message #6 by gene wright

Hopefully they are both fixed. So are complex constants and complex RCL which were also broken by recent changes.

At least, they will be when we do a new build.

- Pauli


[ Return to Index | Top of Index ]

Go back to the main exhibit hall